iamaleksey commented on PR #4774: URL: https://github.com/apache/cassandra/pull/4774#issuecomment-4359877465
Pushed pt. 1 of the changes, but there is more to do. As part of the audit, reviewed existing implementations of MT serializers and fixed some low hanging fruit issues: hand-rolled collection serializers, use of fixed size ints for known small int values (instead of vints), etc. Doing the rest correctly is actually relatively involved. We have MT structures interleaved in non-MT structures in a few places (such as mutation id inside `Mutation`, coordinator ack info in `Message` param map, the interleaving in `IDataResponse`, MT structures inside regular streaming messages, and in `SSTableMetadata`). Some of these can simply be made unversioned (`MutationId`, some need to either be made unversioned or be moved inside an MT message (coordinator ack info), some should be pulled out of non-MT structures altogether. There are also odd parallel versioning schemes running (think `serializationVersion` inside `TrackedDataResponse`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
