iamaleksey commented on PR #4774: URL: https://github.com/apache/cassandra/pull/4774#issuecomment-4336575078
At the high level, I think this is done on a slightly wrong level. `MutationTrackingSerializer` writes out the version even for nested serializers, redundantly - instead of it being specified just once at the outermost point - just for MT related messages. Accord does this better I believe - with `EmbeddedAsymmetricVersionedSerializer`, which we could reuse. It's probably the wrong thing to introduce a different *style* of sub-messaging-service versioning here. Should mimic how Accord does it, and, where makes sense, reuse some of its code as well - but not have two parallel approaches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
