iamaleksey commented on code in PR #4774:
URL: https://github.com/apache/cassandra/pull/4774#discussion_r3155045629
##########
src/java/org/apache/cassandra/replication/MutationId.java:
##########
@@ -157,13 +156,14 @@ public MutationId deserialize(DataInputPlus in, int
version) throws IOException
}
@Override
- public long serializedSize(MutationId id, int version)
+ public long serializedSize(MutationId id, Version version)
{
return TypeSizes.sizeof(id.logId()) +
TypeSizes.sizeof(id.sequenceId());
}
public void skip(DataInputPlus in, int version) throws IOException
{
+ in.readByte();
Review Comment:
I can see that this skips the version, but it could be made more clear.
Also, realizing that we are writing out a mutation id (now 1 byte fatter)
for all mutations, even if if a keyspace has no mutation tracking enabled, for
`none()`, and I don't think that is fine - that's 17 bytes of waste for folks
not opted into MT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
