iamaleksey commented on code in PR #4774:
URL: https://github.com/apache/cassandra/pull/4774#discussion_r3155101258


##########
src/java/org/apache/cassandra/replication/MutationId.java:
##########
@@ -157,13 +156,14 @@ public MutationId deserialize(DataInputPlus in, int 
version) throws IOException
         }
 
         @Override
-        public long serializedSize(MutationId id, int version)
+        public long serializedSize(MutationId id, Version version)
         {
             return TypeSizes.sizeof(id.logId()) + 
TypeSizes.sizeof(id.sequenceId());
         }
 
         public void skip(DataInputPlus in, int version) throws IOException
         {
+            in.readByte();

Review Comment:
   I reckon we could use `0` byte for `none()` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to