On Thu, Sep 9, 2021 at 5:53 PM Bossart, Nathan <bossa...@amazon.com> wrote: > For 0001, the biggest thing on my mind at the moment is the name of > the GUC. "huge_pages_required" feels kind of ambiguous. From the > name alone, it could mean either "the number of huge pages required" > or "huge pages are required for the server to run." Also, the number > of huge pages required is not actually required if you don't want to > run the server with huge pages.
+1 to all of that. > I think it might be clearer to > somehow indicate that the value is essentially the size of the main > shared memory area in terms of the huge page size, but I'm not sure > how to do that concisely. Perhaps it is enough to just make sure the > description of "huge_pages_required" is detailed enough. shared_memory_size_in_huge_pages? It's kinda long, but a long name that you can understand without reading the docs is better than a short one where you can't. -- Robert Haas EDB: http://www.enterprisedb.com
