> On 18 Nov 2020, at 02:31, Michael Paquier <mich...@paquier.xyz> wrote: > > On Tue, Nov 17, 2020 at 09:24:30PM +0100, Daniel Gustafsson wrote: >> I tend to agree, randomness is complicated enough without adding a compile >> time >> extensibility which few (if anyone) will ever use. Attached is an attempt at >> this. > > Going down to that, it seems to me that we could just remove > USE_WIN32_RANDOM (as this is implied by WIN32), as well as > USE_DEV_URANDOM because configure.ac checks for the existence of > /dev/urandom, no? In short, configure.ac could be changed to check > after /dev/urandom if not using OpenSSL and not being on Windows.
Technically that is what it does, except for setting the USE_*RANDOM variables for non-OpenSSL builds. We could skip that too, which I think is what you're proposing, but it seems to me that we'll end up with another set of entangled logic in pg_strong_random if we do since there then needs to be precedence in checking (one might be on Windows with OpenSSL for example, where OpenSSL > Windows API). > -elif test x"$USE_WIN32_RANDOM" = x"1" ; then > +elif test x"$PORTANME" = x"win32" ; then > Typo here, s/PORTANME/PORTNAME. Fixed. cheers ./daniel
v2-0001-Remove-ability-to-choose-randomness-source.patch
Description: Binary data
