Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > On 2020-May-06, Alvaro Herrera wrote: >> This doesn't allow whitespace between "fall" and "through", which means >> we generate 217 such warnings currently. Or we can just use >> -Wimplicit-fallthrough=3, which does allow whitespace (among other >> detritus).
> If we're OK with patching all those places, I volunteer to do so. Any > objections? Or I can keep it at level 3, which can be done with minimal > patching. If we're gonna do it at all, I think we should go for the level 4 warnings. Level 3's idea of a fallthrough comment is too liberal for my tastes... regards, tom lane