On 2020-Apr-12, Tom Lane wrote: > The only more-restrictive alternative, short of disabling > the comments altogether, is > > * -Wimplicit-fallthrough=4 case sensitively matches one of the > following regular expressions: > > *<"-fallthrough"> > *<"@fallthrough@"> > *<"lint -fallthrough[ \t]*"> > *<"[ \t]*FALLTHR(OUGH|U)[ \t]*"> > > Thoughts?
This doesn't allow whitespace between "fall" and "through", which means we generate 217 such warnings currently. Or we can just use -Wimplicit-fallthrough=3, which does allow whitespace (among other detritus). For my own reference, the manual is at https://gcc.gnu.org/onlinedocs/gcc-8.3.0/gcc/Warning-Options.html#index-Wimplicit-fallthrough -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
