At Tue, 01 Oct 2019 19:32:08 +0900 (Tokyo Standard Time), Kyotaro Horiguchi <horikyota....@gmail.com> wrote in <20191001.193208.264851337.horikyota....@gmail.com> > Hello. > > At Sun, 29 Sep 2019 23:51:23 -0500, Joe Nelson <j...@begriffs.com> wrote in > <20190930045123.gc68...@begriffs.com> > > Alvaro Herrera wrote: > > > ... can we have a new patch? > > > > OK, I've attached v4. It works cleanly on 55282fa20f with > > str2int-16.patch applied. My patch won't compile without the other one > > applied too. > > > > Changed: > > [x] revert my changes in common/Makefile > > [x] rename arg_utils.[ch] to option.[ch] > > [x] update @pgfeutilsfiles in Mkvcbuild.pm > > [x] pgindent everything > > [x] get rid of atoi() in more utilities
I didn't checked closely, but -k of pg_standby's message looks somewhat strange. Needs a separator? > pg_standby: -k keepfiles could not parse 'hoge' as integer Building a sentense just concatenating multiple nonindependent (or incomplete) subphrases makes translation harder. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
