Hi Joe, On a quick look, the patch seems to be going in a good direction although there are quite some pending work to be done.
One suggestion: The start value for port number is set to 1, however it seems like the port number that falls in the range of 1-1023 is reserved and can't be used. So, is it possible to have the start value as 1024 instead of 1 ? Further, I encountered one syntax error (INT_MAX undeclared) as the header file "limits.h" has not been included in postgres_fe.h or option.h -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com On Fri, Oct 4, 2019 at 9:04 PM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > On 2019-Oct-03, Joe Nelson wrote: > > > Kyotaro Horiguchi wrote: > > > > pg_standby: -k keepfiles could not parse 'hoge' as integer > > > > > > I didn't checked closely, but -k of pg_standby's message looks > > > somewhat strange. Needs a separator? > > > > Good point, how about this: > > > > pg_standby: -k keepfiles: <localized error message> > > The wording is a bit strange. How about something like > pg_standy: invalid argument to -k: %s > > where the %s is the error message produced like you propose: > > > I could have pg_strtoint64_range() wrap its error messages in _() so > > that translators could customize the messages prior to concatenation. > > > > *error = psprintf(_("could not parse '%s' as integer"), str); > > ... except that they would rather be more explicit about what the > problem is. "insufficient digits" or "extraneous character", etc. > > > Would this suffice? > > I hope that no callers would like to have the messages not translated, > because that seems like it would become a mess. > > -- > Álvaro Herrera https://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services > >
