On Tue, Sep 10, 2019 at 1:36 AM Michael Paquier <mich...@paquier.xyz> wrote: > The error handling is awkward. I think that you should just call > pg_log_error in pg_strtoint64_range instead of returning an error > string as you do. You could do that by passing down the option name > to the routine, and generate a new set of error messages using that.
-1. I think it's very useful to have routines for this sort of thing that return an error message rather than emitting an error report directly. That gives the caller a lot more control. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
