On 2019-09-05 01:59, Michael Paquier wrote: > On Wed, Sep 04, 2019 at 02:37:12PM +0200, Peter Eisentraut wrote: >>>> Do we need set_pglocale_pgservice() calls here if we're not doing NLS? >>>> Does the logging stuff require it? I'm not sure. >>> >>> The logging part does not require it, but this can be used for >>> PGSYSCONFDIR, no? >> >> How does PGSYSCONFDIR come into play here? > > There is an argument to allow libpq to find out a service file for > a connection from the executable path. Note that oid2name can use a > connection string for connection, but not vacuumlo, so I somewhat > missed that.
Oh I see what's going on. PGSYSCONFDIR is used by libpq, and set_pglocale_pgservice() does some path mangling on PGSYSCONFDIR if set for Windows. Shouldn't libpq do that itself? Worth looking into but probably unrelated to your patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
