On 2019-08-20 03:28, Michael Paquier wrote:
> + pg_log_error("\nfailed to remove lo %u:
> %s", lo,
> +
> PQerrorMessage(conn));This newline should be removed. progname can probably be made into a local variable now. The rest looks good to me. Do we need set_pglocale_pgservice() calls here if we're not doing NLS? Does the logging stuff require it? I'm not sure. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
