On 2019-09-04 14:17, Michael Paquier wrote: >> progname can probably be made into a local variable now. > > Can it? vacuumlo() still uses the progname from _param for the > connection string.
Yeah, probably best to leave it as is for now. >> Do we need set_pglocale_pgservice() calls here if we're not doing NLS? >> Does the logging stuff require it? I'm not sure. > > The logging part does not require it, but this can be used for > PGSYSCONFDIR, no? How does PGSYSCONFDIR come into play here? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services