Hello David,

Patch applies. There seems to be a compilation issue:

 describe.c:5974:1: error: expected declaration or statement at end of
 input
  }

This is in brown paper bag territory. Fixed.

I do not understand why you move both size and description out of the verbose mode, it should be there only when under verbose?

I've sent a separate patch extracted from the one you sent which adds
stdin to our TAP testing infrastructure. I hope it lands so it'll be
simpler to add these tests in a future version of the patch.

Why not. As I'm the one who wrote the modified function, probably I could have thought of providing an input. I'm not sure it is worth a dedicated submission, could go together with any commit that would use it.

--
Fabien.


Reply via email to