Hello David,
Patch applies. There seems to be a compilation issue:
describe.c:5974:1: error: expected declaration or statement at end of
input
}
Also there is an added indentation problem: the size & description stuff
have been moved left but it should still in the verbose case, and a } is
missing after them, which fixes the compilation.
Make check fails because of my temp schema was numbered 4 instead of 3, and
I'm "fabien" rather than "shackle".
I think the way forward is to test this with TAP rather than the
fixed-string method.
Ok.
Checks removed while I figure out a new TAP test.
I only have packages down to pg 9.3, so I could not test prior 9.1.
By looking at the online documentation, is seems that relistemp
appears in pg 8.4, so the corresponding extraction should be guarded
by this version. Before that, temporary objects existed but were
identified indirectly, possibly because they were stored in a
temporary schema. I suggest not to try to address cases prior 8.4.
Done.
After some checking, I think that there is an issue with the version
numbers:
- 9.1 is 90100, not 91000
- 8.4 is 80400, not 84000
Also, it seems that describes builds queries with uppercase keywords, so
probably the new additions should follow that style: case -> CASE (and
also when then else end as…)
--
Fabien.
