On Wed, 24 Apr 2019 at 10:30, Fabien COELHO <coe...@cri.ensmp.fr> wrote: > > > Hello David, > > >>> I noticed that there wasn't a bulk way to see table logged-ness in psql, > >>> so I made it part of \dt+. > >> > >> Applies, compiles, works for me. > >> > >> ISTM That temporary-ness is not shown either. Maybe the persistence column > >> should be shown as is? > > > > Temporariness added, but not raw. > > Ok, it is better like this way. > > >> Tests? > > > > Included, but they're not stable for temp tables. I'm a little stumped > > as to how to either stabilize them or test some other way. > > Hmmm. First there is the username which appears, so there should be a > dedicated user for the test. > > I'm unsure how to work around the temporary schema number, which is > undeterministic with parallel execution it. I'm afraid the only viable > approach is not to show temporary tables, too bad:-( > > >> Doc? > > > > What further documentation does it need? > > Indeed, there is no precise doc, so nothing to update :-)/:-( > > > Maybe you could consider adding a case for prior 9.1 version, something > like: > ... case c.relistemp then 'temporary' else 'permanent' end as ... > > I was reviewing this patch and found a bug,
create table t (i int); create index idx on t(i); \di+ psql: print.c:3452: printQuery: Assertion `opt->translate_columns == ((void *)0) || opt->n_translate_columns >= cont.ncolumns' failed. -- Regards, Rafia Sabih
