On Fri, Feb 01, 2019 at 09:11:50AM +0100, Laurenz Albe wrote: > Jamison, Kirk wrote: >> I wonder if there is a better reloption name for >> shrink_enabled. (truncate_enabled, vacuum_enabled? Hmm. No?) >> On the other hand, shrink_enabled seems to describe well what it's >> supposed to do when vacuuming tables. Besides there's a >> similarly-named autovacuum_enabled option. > > I like "shrink_enabled". > > It may sound weird in the ears of PostgreSQL hackers, but will make > sense to users. > > Perhaps "vacuum_shrink_enabled" would be even better.
Naming it just vacuum_truncate and autovacuum_truncate (with aliases for toast and such), looks more natural to me. "shrink" is not a term used in the code at all to describe this phase of vacuuming, and this option talks mainly to people who are experts in PostgreSQL internals in my opinion. -- Michael
signature.asc
Description: PGP signature
