Hello. At Wed, 25 Jul 2018 23:08:33 +0900, Michael Paquier <mich...@paquier.xyz> wrote in <20180725140833.gc6...@paquier.xyz> > On Wed, Jul 18, 2018 at 05:58:16PM +0300, Heikki Linnakangas wrote: > > I'd suggest that we continue based on the patch that Kyotaro posted at > > https://www.postgresql.org/message-id/20180330.100646.86008470.horiguchi.kyotaro%40lab.ntt.co.jp. > > Whatever happens here, perhaps one way to move on would be to commit > first the TAP test that I proposed upthread. That would not work for > wal_level=minimal so this part should be commented out, but that's > easier this way to test basically all the cases we talked about with any > approach taken.
https://www.postgresql.org/message-id/20180704045912.gg1...@paquier.xyz However I'm not sure the policy (if any) allows us to add a test that should success, I'm not opposed to do that. But even if we did that, it won't be visible to other than us in this thread. It seems to me more or less similar to pasting a boilerplate that points to the above message in this thread, or just writing "this patch passes "the" test.". regards. -- Kyotaro Horiguchi NTT Open Source Software Center
