On Tue, Jan 28, 2025 at 5:28 PM Nisha Moond <nisha.moond...@gmail.com> wrote: > > On Tue, Jan 28, 2025 at 3:26 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Mon, Dec 30, 2024 at 11:05 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > I think we are often too quick to throw out perfectly good tests. > > > Citing that some similar GUCs don't do testing as a reason to skip > > > them just seems to me like an example of "two wrongs don't make a > > > right". > > > > > > There is a third option. > > > > > > Keep the tests. Because they take excessive time to run, that simply > > > means you should run them *conditionally* based on the PG_TEST_EXTRA > > > environment variable so they don't impact the normal BF execution. The > > > documentation [1] says this env var is for "resource intensive" tests > > > -- AFAIK this is exactly the scenario we find ourselves in, so is > > > exactly what this env var was meant for. > > > > > > Search other *.pl tests for PG_TEST_EXTRA to see some examples. > > > > > > > I don't see the long-running tests to be added under PG_TEST_EXTRA as > > that will make it unusable after some point. Now, if multiple senior > > members feel it is okay to add long-running tests under PG_TEST_EXTRA > > then I am open to considering it. We can keep this test as a separate > > patch so that the patch is being tested in CI or in manual tests > > before commit. > > > > Please find the attached v64 patches. The changes in this version > w.r.t. older patch v63 are as - > - The changes from the v63-0001 patch have been moved to a separate thread > [1]. > - The v63-0002 patch has been split into two parts in v64: > 1) 001 patch: Implements the main feature - inactive timeout-based > slot invalidation. > 2) 002 patch: Separates the TAP test "044_invalidate_inactive_slots" > as suggested above. > > [1] > https://www.postgresql.org/message-id/CABdArM6pBL5hPnSQ%2B5nEVMANcF4FCH7LQmgskXyiLY75TMnKpw%40mail.gmail.com >
Please find the v65 patch set attached with following changes: - patch-0001 is the copy of v4-001 patch used as a base patch from [1], as suggested by Peter in [2]. - patch-0002 is the main patch implementing the feature, this has also addressed the comments from [2] and [3] - patch-0003 adds an alternative approach for the TAP test using injection points to force idle_timeout slot invalidation without waiting for a minute. This test takes 2-3 seconds to complete. - patch-0004 maintains the previous test(v64-0002) which is under PG_TEST_EXTRA. Also, addressed Vignesh's comments [4] for the test and now it takes 70-80 seconds to complete. Note: Patches 0003 and 0004 contain the same TAP test but use different verification methods. We need to decide which one to keep. [1] https://www.postgresql.org/message-id/CALDaNm1ZUHnKm%2BPSjjqRrMxcLagrUTS6SADnEsQBfW8rMZFrDA%40mail.gmail.com [2] https://www.postgresql.org/message-id/CAHut%2BPtyUQGee6pHkNN3-ghYhWnY5p-3yWumK7zKupu0S1oVQQ%40mail.gmail.com [3] https://www.postgresql.org/message-id/CALDaNm1J_mdqCYjQZgfQMVhJrxndPem5ruxpG_67t4C_2My9WQ%40mail.gmail.com [4] https://www.postgresql.org/message-id/CALDaNm2dAJB%3DfJ2X7EMb7meNTjMyL-%2B-xA93JL_jPkGF4%3DRUYw%40mail.gmail.com Thank you, Kuroda-san for providing the TAP test using injection points (patch-0003). -- Thanks, Nisha
v65-0001-Raise-Error-for-Invalid-Slots-in-ReplicationSlot.patch
Description: Binary data
v65-0002-Introduce-inactive_timeout-based-replication-slo.patch
Description: Binary data
v65-0003-Add-TAP-test-for-slot-invalidation-based-on-inac.patch
Description: Binary data
v65-0004-Add-TAP-test-for-slot-invalidation-based-on-inac.patch
Description: Binary data
