On Tue, Jan 28, 2025 at 3:26 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Dec 30, 2024 at 11:05 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > I think we are often too quick to throw out perfectly good tests. > > Citing that some similar GUCs don't do testing as a reason to skip > > them just seems to me like an example of "two wrongs don't make a > > right". > > > > There is a third option. > > > > Keep the tests. Because they take excessive time to run, that simply > > means you should run them *conditionally* based on the PG_TEST_EXTRA > > environment variable so they don't impact the normal BF execution. The > > documentation [1] says this env var is for "resource intensive" tests > > -- AFAIK this is exactly the scenario we find ourselves in, so is > > exactly what this env var was meant for. > > > > Search other *.pl tests for PG_TEST_EXTRA to see some examples. > > > > I don't see the long-running tests to be added under PG_TEST_EXTRA as > that will make it unusable after some point. Now, if multiple senior > members feel it is okay to add long-running tests under PG_TEST_EXTRA > then I am open to considering it. We can keep this test as a separate > patch so that the patch is being tested in CI or in manual tests > before commit. >
Please find the attached v64 patches. The changes in this version w.r.t. older patch v63 are as - - The changes from the v63-0001 patch have been moved to a separate thread [1]. - The v63-0002 patch has been split into two parts in v64: 1) 001 patch: Implements the main feature - inactive timeout-based slot invalidation. 2) 002 patch: Separates the TAP test "044_invalidate_inactive_slots" as suggested above. [1] https://www.postgresql.org/message-id/CABdArM6pBL5hPnSQ%2B5nEVMANcF4FCH7LQmgskXyiLY75TMnKpw%40mail.gmail.com -- Thanks, Nisha
v64-0001-Introduce-inactive_timeout-based-replication-slo.patch
Description: Binary data
v64-0002-Add-TAP-test-for-slot-invalidation-based-on-inac.patch
Description: Binary data