On Mon, Dec 16, 2024 at 9:40 PM Nisha Moond <nisha.moond...@gmail.com> wrote: > > On Mon, Dec 16, 2024 at 9:58 AM Peter Smith <smithpb2...@gmail.com> wrote: > > ... > > SUGGESTIONS: > > > > Docs (idle_replication_slot_timeout): Invalidate replication slots > > that have remained idle longer than this duration. > > Docs (idle_timeout): means that the slot has remained idle longer than > > the configured idle_replication_slot_timeout duration. > > > > Code (guc var comment): Invalidate replication slots that have > > remained idle longer than this duration. > > Code (guc_tables): Sets the duration a replication slot can remain > > idle before it is invalidated. > > > > Msg (errdetail): This slot has been invalidated because it has > > remained idle longer than the configured \"%s\" duration. > > Msg (errdetail): The slot has remained idle since %s, which is longer > > than the configured \"%s\" duration. > > > > Here is the v56 patch set with the above comments incorporated. >
Hi Nisha. Thanks for the updates. - Both patches could be applied cleanly. - Tests (make check, TAP subscriber, TAP recovery) are all passing. - The rendering of the documentation changes from patch 0002 looked good. - I have no more review comments. So, the v56* patchset LGTM. ====== Kind Regards, Peter Smith. Fujitsu Australia
