On Mon, Dec 16, 2024 at 9:58 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi Nisha. > > Thanks for the v55* patches. > > I have no comments for patch v55-0001. > > I have only 1 comment for patch v55-0002 regarding some remaining > nitpicks (below) about the consistency of phrases. > > ====== > > SUGGESTIONS: > > Docs (idle_replication_slot_timeout): Invalidate replication slots > that have remained idle longer than this duration. > Docs (idle_timeout): means that the slot has remained idle longer than > the configured idle_replication_slot_timeout duration. > > Code (guc var comment): Invalidate replication slots that have > remained idle longer than this duration. > Code (guc_tables): Sets the duration a replication slot can remain > idle before it is invalidated. > > Msg (errdetail): This slot has been invalidated because it has > remained idle longer than the configured \"%s\" duration. > Msg (errdetail): The slot has remained idle since %s, which is longer > than the configured \"%s\" duration. >
Here is the v56 patch set with the above comments incorporated. -- Thanks Nisha
v56-0001-Enhance-replication-slot-error-handling-slot-inv.patch
Description: Binary data
v56-0002-Introduce-inactive_timeout-based-replication-slo.patch
Description: Binary data
