Hi Nisha. Thanks for the v55* patches.
I have no comments for patch v55-0001. I have only 1 comment for patch v55-0002 regarding some remaining nitpicks (below) about the consistency of phrases. ====== I scanned again over all the phrases for consistency: CURRENT PATCH: Docs (idle_replication_slot_timeout): Invalidate replication slots that are idle for longer than this amount of time Docs (idle_timeout): means that the slot has remained idle longer than the duration specified by the idle_replication_slot_timeout parameter. Code (guc var comment): Invalidate replication slots idle longer than this time Code (guc_tables): Sets the time limit for how long a replication slot can remain idle before it is invalidated. Msg (errdetail): This slot has been invalidated because it has remained idle longer than the configured \"%s\" time. Msg (errdetail): The slot has been inactive since %s and has remained idle longer than the configured \"%s\" time. ~ NITPICKS: nit -- There are still some variations "amount of time" versus "time" versus "duration". I think the term "duration" best describe the maing so we can use that everywhere. nit - Should consistently say "remained idle" instead of just "idle" or "are idle", nit - The last errdetail is also rearranged a bit because IMO we don't need to say inactive and idle in the same sentence. nit - Just say "longer than" instead of sometimes saying "for longer than" ~ SUGGESTIONS: Docs (idle_replication_slot_timeout): Invalidate replication slots that have remained idle longer than this duration. Docs (idle_timeout): means that the slot has remained idle longer than the configured idle_replication_slot_timeout duration. Code (guc var comment): Invalidate replication slots that have remained idle longer than this duration. Code (guc_tables): Sets the duration a replication slot can remain idle before it is invalidated. Msg (errdetail): This slot has been invalidated because it has remained idle longer than the configured \"%s\" duration. Msg (errdetail): The slot has remained idle since %s, which is longer than the configured \"%s\" duration. ====== Kind Regards, Peter Smith. Fujitsu Australia
