On Wed, Nov 27, 2024 at 04:00:14PM +0000, Bertrand Drouvot wrote: > I'd vote to just keep the pgstat_create_backend_stat() call in > pgstat_beinit(). > > That said, we probably should document that init_backend_cb() should not call > pgstat_get_entry_ref(), but that's probably worth another thread.
Hmm, yeah. I have considered this point and your approach does not seem that bad to me after thinking much more about it, and you are putting the call in pgstat_beinit(), which is about initializing the stats for the backend. So I'm OK with what the patch does here in terms of the location where pgstat_create_backend_stat() is called. -- Michael
signature.asc
Description: PGP signature
