On Thu, Nov 21, 2024 at 05:23:42PM +0000, Bertrand Drouvot wrote: > So, given that: > > - the end result would be the same > - the code changes would be non negligible (unless we have a better idea than > pgstat_get_entry_ref() returning a NULL value).
Hmm. created_entry only matters for pgstat_init_function_usage(). All the other callers of pgstat_prep_pending_entry() pass a NULL value. This makes me wonder if there is an argument for reworking a bit that. There's a fat comment about the reason why, still, that would make the get interface for variable-numbered stats a lot leaner.. Not sure what to think about that. -- Michael
signature.asc
Description: PGP signature
