On Thu, Sep 05, 2024 at 03:59:53PM +0300, Nazir Bilal Yavuz wrote: > On Wed, 4 Sept 2024 at 21:43, Noah Misch <n...@leadboat.com> wrote: > > https://postgr.es/m/caeudqaozv3wty5tv2t29jcwpydbmkbiwqkzd42s2ogzdixp...@mail.gmail.com > > then observed that collect_corrupt_items() was now guaranteed to never > > detect > > corruption. I have pushed revert ddfc556 of the pg_visibility.c changes. > > For > > the next try, could you add that testing we discussed? > > Do you think that corrupting the visibility map and then seeing if > pg_check_visible() and pg_check_frozen() report something is enough?
I think so. Please check that it would have caught both the blkno bug and the above bug.
