Hi, On Wed, 11 Sept 2024 at 01:38, Noah Misch <n...@leadboat.com> wrote: > > On Tue, Sep 10, 2024 at 02:35:46PM +0300, Nazir Bilal Yavuz wrote: > > Your patch is correct. I wrongly assumed it would catch blockno bug, > > the attached version catches it. I made blockno = 0 invisible and not > > frozen before copying the vm file. So, in the blockno buggy version; > > callback will skip that block but the main loop in the > > collect_corrupt_items() will not skip it. I tested it with your patch > > and there is exactly 1 blockno difference between expected and result > > output. > > Pushed. I added autovacuum=off so auto-analyze of a system catalog can't take > a snapshot that blocks VACUUM updating the vismap. I doubt that could happen > under default settings, but this lets us disregard the possibility entirely.
Thanks! > I also fixed the mix of tabs and spaces inside test file string literals. I ran both pgindent and pgperltidy but they didn't catch them. Is there an automated way to catch them? -- Regards, Nazir Bilal Yavuz Microsoft