On Tue, Sep 03, 2024 at 10:46:34PM +0300, Nazir Bilal Yavuz wrote: > On Tue, 3 Sept 2024 at 22:20, Noah Misch <n...@leadboat.com> wrote: > > On Tue, Sep 03, 2024 at 10:50:11AM -0700, Noah Misch wrote: > > > Pushed with some other cosmetic changes. > > Thanks! > > > I see I pushed something unacceptable under ASAN. I will look into that: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=grassquit&dt=2024-09-03%2017%3A47%3A20 > > I think it is related to the scope of BlockRangeReadStreamPrivate in > the collect_visibility_data() function. Attached a small fix for that.
Right. https://postgr.es/m/caeudqaozv3wty5tv2t29jcwpydbmkbiwqkzd42s2ogzdixp...@mail.gmail.com then observed that collect_corrupt_items() was now guaranteed to never detect corruption. I have pushed revert ddfc556 of the pg_visibility.c changes. For the next try, could you add that testing we discussed?
