Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.

ralf_lici has posted comments on this change by ralf_lici. ( 
http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email )

Change subject: dco-freebsd: store peer stats directly in c2
......................................................................


Patch Set 3:

(1 comment)

File src/openvpn/dco_freebsd.c:

http://gerrit.openvpn.net/c/openvpn/+/1275/comment/75cffd49_b9737742?usp=email :
PS2, Line 625:                 dco->c->c2.dco_write_bytes = 
nvlist_get_number(bytes, "out");
> actually if you check `dco_update_peer_stat()` it already does the right 
> thing, similarly to what Ge […]
Yeah, you're right, the peer stats we're parsing here should go into the 
correct `multi_instance` context rather than the general server context. I went 
with Antonio's suggestion and reused `dco_update_peer_stat()`, which already 
handles this properly.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84
Gerrit-Change-Number: 1275
Gerrit-PatchSet: 3
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Sun, 19 Oct 2025 08:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to