Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email )
Change subject: dco-freebsd: store peer stats directly in c2 ...................................................................... Patch Set 2: (1 comment) File src/openvpn/dco_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/1275/comment/eaa99283_eaf32505?usp=email : PS2, Line 625: dco->c->c2.dco_write_bytes = nvlist_get_number(bytes, "out"); > I don't think this is the correct place to store these. […] actually if you check `dco_update_peer_stat()` it already does the right thing, similarly to what Gert is alluding to. Maybe this function can be re-used while parsing `OVPN_NOTIF_DEL_PEER`? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84 Gerrit-Change-Number: 1275 Gerrit-PatchSet: 2 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Sat, 18 Oct 2025 21:29:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
