LGTM.
—
Kristof
On 15 Oct 2025, at 9:25, ralf_lici (Code Review) wrote:
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email
to review the following change.
Change subject: dco-freebsd: store peer stats directly in c2
......................................................................
dco-freebsd: store peer stats directly in c2
The dco_context_t structure includes a reference to the general
context
structure c, which allows us to store dco_read_bytes and
dco_write_bytes
directly as c2 fields. This aligns the FreeBSD implementation with how
we handle DCO peer stats on Linux and Windows.
Change-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84
Signed-off-by: Ralf Lici <[email protected]>
---
M src/openvpn/dco_freebsd.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn
refs/changes/75/1275/1
diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c
index b9f6bc7..5791257 100644
--- a/src/openvpn/dco_freebsd.c
+++ b/src/openvpn/dco_freebsd.c
@@ -621,8 +621,8 @@
{
const nvlist_t *bytes = nvlist_get_nvlist(nvl,
"bytes");
- dco->dco_read_bytes = nvlist_get_number(bytes, "in");
- dco->dco_write_bytes = nvlist_get_number(bytes,
"out");
+ dco->c->c2.dco_read_bytes = nvlist_get_number(bytes,
"in");
+ dco->c->c2.dco_write_bytes = nvlist_get_number(bytes,
"out");
}
dco->dco_message_type = OVPN_CMD_DEL_PEER;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84
Gerrit-Change-Number: 1275
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
