Attention is currently required from: flichtenheld, plaisthos, ralf_lici. cron2 has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email )
Change subject: dco-freebsd: store peer stats directly in c2 ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: I think this needs more discussion on which counters on what event and in what mode (client side / CM_P2P vs. server side) to put where File src/openvpn/dco_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/1275/comment/4f9c725c_42b0c79e?usp=email : PS2, Line 625: dco->c->c2.dco_write_bytes = nvlist_get_number(bytes, "out"); I don't think this is the correct place to store these. The overall context here is "OVPN_NOTIF_DEL_PEER", so we're told by the kernel that `dco->dco_message_peer_id` went away, and, btw, here are the latest counters for this peer. Storing it in `dco->c->c2->` smells like "the server's global structure" while Linux would put per-client into `dco->c->multi->instances[peer_id]->context.c2->` - OTOH, Linux' `CMD_PEER_DEL_NTF` seems to carry no counters, so the code is not the same anyway. Am I misreading this? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1275?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84 Gerrit-Change-Number: 1275 Gerrit-PatchSet: 2 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Sat, 18 Oct 2025 17:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
