Attention is currently required from: flichtenheld, its_Giaan, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/763?usp=email )

Change subject: multiproto: move generic event handling code in dedicated files
......................................................................


Patch Set 13:

(2 comments)

Patchset:

PS13:
close :-) (the code compiles and passes light tests, but there is a comment 
that is more confusing than helpful)


File src/openvpn/multi.h:

http://gerrit.openvpn.net/c/openvpn/+/763/comment/d62d69ef_43444458 :
PS13, Line 180:                                     *   transport. */
getting close... but this comment does not make sense.  What is it that is 
stored here?  Are there other protocols but UDP and TCP?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/763?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1e5a84969988e4f027a18658d4ab268c13fbf929
Gerrit-Change-Number: 763
Gerrit-PatchSet: 13
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: its_Giaan <gianma...@mandelbit.com>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Thu, 23 Jan 2025 17:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to