Attention is currently required from: cron2, flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/763?usp=email )
Change subject: multiproto: move generic event handling code in dedicated files ...................................................................... Patch Set 11: (14 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/3cd77970_c262e6d2 : PS10, Line 4926: struct link_socket *sock) > I agree that we might want to make this uniform across the whole code - that > is, change all occurenc […] Done File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/8fab14f7_8836c8e6 : PS10, Line 165: multi_tcp_context(struct multi_context *m, struct multi_instance *mi) > we lost the `inline` bit here by making it a global function. Maybe move it > to mtcp. […] made this static inline again and moved to multi_io.h where it gets used, also renamed this 'multi_get_context' since it's what it does. File src/openvpn/mudp.h: http://gerrit.openvpn.net/c/openvpn/+/763/comment/1ee1261f_36899e3a : PS10, Line 66: struct link_socket *sock); > see other comment, please move pure `ls/sock` renaming to a different patch Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/8f0f41f9_ca89d73c : PS10, Line 189: struct link_socket *sock) > and here... without the renaming, there wouldn't be a change to `mudp. […] Done File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/763/comment/18a4cbd0_54aa4b1c : PS10, Line 178: struct multi_protocol *multi_io; /**< State specific to OpenVPN using TCP > If it's still `specific to TCP` (as the comment says), why rename it to > `multi_protocol`? This is c […] It gets used also by UDP, the comment was a leftover. http://gerrit.openvpn.net/c/openvpn/+/763/comment/048d18f2_978d730d : PS10, Line 280: struct link_socket *sock); > this Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/bd02fcba_e322ec4d : PS10, Line 295: struct link_socket *sock); > and that Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/9169a686_317e9b71 : PS10, Line 363: struct link_socket *sock); > and yet another one Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/d56445cb_e795fd77 : PS10, Line 754: struct link_socket *sock) > another rename Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/a0585c59_7f074ee2 : PS10, Line 777: inherit_context_child(&mi->context, &m->top, sock); > and this Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/aa433935_03f4722e : PS10, Line 3129: struct link_socket *sock) > here Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/d202b209_59ae6a8b : PS10, Line 3185: mi->context.c2.link_sockets[0] = sock; > and there Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/78a7791f_6b0bda67 : PS10, Line 3335: const unsigned int mpp_flags, struct link_socket *sock) > and here... Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/4849bfa6_a38eaef1 : PS10, Line 3356: multi_set_pending(m, multi_get_create_instance_udp(m, &floated, sock)); > this gets a bit boring Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/763?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1e5a84969988e4f027a18658d4ab268c13fbf929 Gerrit-Change-Number: 763 Gerrit-PatchSet: 11 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 13:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
