Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/763?usp=email )
Change subject: multiproto: move generic event handling code in dedicated files ...................................................................... Patch Set 12: Code-Review-1 (2 comments) Patchset: PS12: much better and much easier reviewed now. As discussed on IRC, the `multi_protocol_...()` function names are slightly confusing, and I suggest to use `multi_io_...()`, which is in line with the `m->mtcp` to `m->m_multi_io` renaming and also the file names... File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/506eec5d_80c39ac0 : PS10, Line 165: multi_tcp_context(struct multi_context *m, struct multi_instance *mi) > made this static inline again and moved to multi_io. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/763?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1e5a84969988e4f027a18658d4ab268c13fbf929 Gerrit-Change-Number: 763 Gerrit-PatchSet: 12 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 23 Jan 2025 15:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: its_Giaan <gianma...@mandelbit.com> Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
