Hi, On Wed, Oct 24, 2018 at 9:00 AM David Sommerseth <open...@sf.lists.topphemmelig.net> wrote: > > On 24/10/18 14:39, Selva Nair wrote: > > On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli <a...@unstable.cc> wrote: > >> > >> Hi, > >> > > > > > > Also there is a misplaced and mismatched comment added to > > buffer.c that says > > > > + /* vswprintf is missing in OpenBSD 4.2 */ > > len = vswprintf(str, size, format, arglist); > > > > Makes little sense in that context and why 4.2.. > > That one could be removed. > I'd say we should have such a reference in right below the #ifdef _WIN32 a few > lines higher up. And it could be slightly more informative (and should > reference OpenBSD 4.9, which is the distro exploding without this patch.
Yes, that's why I wrote "misplaced" and "mismatched" :) > I suggest the comment below the #ifdef _WIN32 to be something like: > > /* > * openvpn_swprintf() is currently only used by Windows code paths > * and when enabled for all platforms it will currently break > * OpenBSD 4.9 which lacks vswprintf(3) support in its libc. > */ Looks good except, <=4.9, not just 4.9, or whatever version is appropriate. (As Antonio already pointed out.) Selva _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
