On Mon, Oct 22, 2018 at 2:38 PM Gert Doering <g...@greenie.muc.de> wrote: > > Your patch has been applied to the master branch. > > I'm not sure I totally like the change to buffer.c/tun.c - for the > single instance where this is called inside openvpn/tun.c, on WIN32, > we now carry around a new function in buffer.c which is compiled > everywhere... possibly breaking older systems that have C99 compliant > C compilers but no full C99 library - like my oldest OpenBSD > buildslave (our mantra on that is "if it breaks for good reasons, > it will be retired, but we shouldn't carelessly break things").
Good point. We should never need (v)swprintf on non-windows platforms as keeping strings in utf8 should be the preferred way. Enclosing this inside #ifdef _WIN32 sounds good. My bad to be too much fixated on Windows during review.. Selva _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
