Your patch has been applied to the master branch.
I'm not sure I totally like the change to buffer.c/tun.c - for the
single instance where this is called inside openvpn/tun.c, on WIN32,
we now carry around a new function in buffer.c which is compiled
everywhere... possibly breaking older systems that have C99 compliant
C compilers but no full C99 library - like my oldest OpenBSD
buildslave (our mantra on that is "if it breaks for good reasons,
it will be retired, but we shouldn't carelessly break things").
So if we really want to keep this, it should be #ifdef _WIN32 (until
we find good uses for wide-sprintf() on other platforms).
For the service, which is windows-only code, this change is clearly
reasonable and beneficial.
commit 43a5a4f3b4e411419639c195fee8a76495fdc88e
Author: Lev Stipakov
Date: Mon Oct 22 13:19:31 2018 +0300
Introduce openvpn_swprintf() with nul termination guarantee
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Selva Nair <selva.n...@gmail.com>
Message-Id: <1540203571-17646-1-git-send-email-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17786.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
