On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli <a...@unstable.cc> wrote:
>
> Hi,
>
> On 23/10/18 22:51, Lev Stipakov wrote:
> > From: Lev Stipakov <l...@openvpn.net>
> >
> > Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added
> > vswprintf() call which turned to me missing in OpenBSD 4.9.
> >
> > Since that call is inside openvpn_swprintf() function which
> > is only used by Windows, wrap that function info #ifdef _WIN32.
> >
> > Signed-off-by: Lev Stipakov <l...@openvpn.net>
>
> This patch introduces another ifdef, but it is enclosing a whole
> function to prevent it from being compiled on non-windows platforms,
> therefore I consider it "acceptable" for the time being.
>
> This patch fixes building openvpn on OpenBSD <= 4.9 (maybe this info
> should be added to the commit message).
Also there is a misplaced and mismatched comment added to
buffer.c that says
+ /* vswprintf is missing in OpenBSD 4.2 */
len = vswprintf(str, size, format, arglist);
Makes little sense in that context and why 4.2..
That one could be removed.
Otherwise an ACK from me too.
Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
