On Saturday 28 November 2009, Marek Vasut wrote:
> > > +static int xscale_version = XSCALE_IXP4XX_PXA2XX;
> > 
> > Please put this in the instance-specific struct ... this approach
> > obviously breaks on a board with both a PXA2xx and a PXA3xx.
> 
> Have you ever seen such a mutant ? Come on ...

Bad design is bad design.  This is trivial to fix, and preventing
such bugs from appearing in the first place is better than trying
to troubleshoot them in the field later on.


> btw. where should I look for that instance-specific struct ?

Did you look at "xscale.h"?  That's where I'd start.  There
turns out to be a "struct xscale_common", go figure.  ;)



_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to