On Saturday 28 November 2009, Marek Vasut wrote:

> @@ -70,6 +70,13 @@ static int xscale_set_watchpoint(struct target *, struct
> watchpoint *); static int xscale_unset_breakpoint(struct target *, struct
> breakpoint *); static int xscale_read_trace(struct target *);
>
> +/* This variable determines which CPU we are connecting to.
> + *
> + * Possible values are:
> + *   0 - For PXA2xx and IXP4xx (default).
> + *   4 - For PXA3xx, which has JTAG Instructions shifted by four to left.
> + */
> +static int xscale_version = XSCALE_IXP4XX_PXA2XX;

Please put this in the instance-specific struct ... this approach
obviously breaks on a board with both a PXA2xx and a PXA3xx.


Other than that, it looks OK ... and I'll likely merge it after the
tree starts working well enough for me that I can re-test two other
XScale patches that are queued ahead of it.

- Dave
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to