On Thursday 29 October 2009, Freddie Chopin wrote: > 1. When using lpc2103.cfg or stm32.cfg (probably many other target > scripts) when started OpenOCD warns: > > > Warn : use 'lpc2103.cpu' as target identifier, not '0' > > which is because lines like: > > > flash bank stm32x 0 0 0 0 0 > > which should be > > > flash bank stm32x 0 0 0 0 $_TARGETNAME
Yes, thanks for catching these. > see the attached patch nr1. Which curiously was the *second* attachment; and the first one wasn't nr0. ;) > I've tested only stm32.cfg and lpc2103.cfg - > the change fixes the warning. All other config files were NOT tested! Hmmm ... we're at RC0, which means I've now got my "avoid merging patches" hat. Tested patches are by and large OK when they fix bugs, and getting rid of these warnings passes my "ok to merge" filter. And in this case think it's clear the other LPC files have the same fix, so they are "obviously" OK too. Ditto the CFI flash ... though most of those should become *board* configs not target configs. But unless some other maintainer is happier with merging untested stuff, I'll ask you to trim this down to just the stuff you tested, plus LPC and CFI changes. > From: Freddie Chopin <freddie_cho...@op.pl> > Date: Thu, 29 Oct 2009 19:23:05 +0100 > Subject: [PATCH 1/2] add $_TARGETNAME instead of 0 to .cfg files to get rid > of runtime warning (changes were NOT tested, but should be correct (; ) > > --- > tcl/target/aduc702x.cfg | 2 +- aduc, untested > tcl/target/at91eb40a.cfg | 2 +- ecos, untested > tcl/target/at91r40008.cfg | 2 +- CFI, presumably OK > tcl/target/at91sam7sx.cfg | 2 +- sam7, untested (and see below re strings-of-zeroes) > tcl/target/epc9301.cfg | 2 +- CFI, presumably OK > tcl/target/faux.cfg | 2 +- faux, untested > tcl/target/lpc1768.cfg | 2 +- another LPC, presumably OK > tcl/target/lpc2103.cfg | 2 +- lpc2103 tested > tcl/target/lpc2124.cfg | 2 +- > tcl/target/lpc2129.cfg | 2 +- > tcl/target/lpc2148.cfg | 2 +- > tcl/target/lpc2294.cfg | 2 +- > tcl/target/lpc2378.cfg | 2 +- > tcl/target/lpc2478.cfg | 2 +- other LPCs, presumably OK > tcl/target/mega128.cfg | 2 +- > tcl/target/pic32mx.cfg | 4 ++-- > tcl/target/sam7se512.cfg | 2 +- > tcl/target/sam7x256.cfg | 2 +- four non-tested configs, change doesn't match any tested config. Inclined to NAK until the merge window for 0.4.x opens. Especially the sam7 stuff ... changing the right zero in the middle of those nasty strings of zeroes could easily break (and "broken" is worse than "annoying/needless warning). > tcl/target/smdk6410.cfg | 2 +- CFI, presumably OK (this is really a BOARD config) > tcl/target/stm32.cfg | 2 +- stm32 tested > tcl/target/str710.cfg | 4 ++-- > tcl/target/str730.cfg | 2 +- > tcl/target/str750.cfg | 4 ++-- > tcl/target/str912.cfg | 4 ++-- STR7/STR9, not tested > tcl/target/xba_revA3.cfg | 2 +- CFI, presumably OK > 25 files changed, 29 insertions(+), 29 deletions(-) _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
