On Fri, 8 Nov 2024 22:06:11 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Replace 'TODO: SM removal:' comments with 'TODO: JDK-nnnnnnn:'
>> - Additional cleanup of unused fields, imports, and comments related to
>> permissions
>> - Review comments: remove unused field, methods in FXMLLoader
>
> modules/javafx.base/src/main/java/com/sun/javafx/reflect/ReflectUtil.java
> line 82:
>
>> 80: */
>> 81: public static void checkPackageAccess(String name) {
>> 82: @SuppressWarnings("removal")
>
> will there be a ticket for further cleanup of unused/unnecessary methods?
Since this class is derived from the similar JDK class, I want to be informed
by what they do after the SM removal JEP is integrated. I filed
[JDK-8344117](https://bugs.openjdk.org/browse/JDK-8344117) as a Task to track
this, which may or may not lead to a follow-up bug.
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/FontFactory.java
> line 55:
>
>> 53: public String[] getFontFullNames(String family);
>> 54:
>> 55: // TODO: SM removal: condider removing in a follow-up issue
>
> maybe it's better to create a ticket and reference that instead?
Good idea. I'll do that.
> modules/javafx.graphics/src/main/java/javafx/scene/input/Dragboard.java line
> 52:
>
>> 50: @Override
>> 51: Object getContentImpl(DataFormat dataFormat) {
>> 52: if (dataAccessRestricted) {
>
> this method can be deleted here
What method? Not `getContentImpl`, since that's the primary method to retrieve
the content and is still used and needed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1838229973
PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1838230883
PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1838231353
