On Fri, 8 Nov 2024 21:46:38 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> Ths PR removes all remaining calls to `System::getSecurityManager` and the > `SecurityManager` class along with the `System.getGecurityManager() != null` > code paths. > > As part of doing this, the last uses of `PermissionHelper` and > `FXPermissions` were eliminated, so I deleted those two classes. Since > `PermissionHelper` was the last remaining use of `AccessControlException`, I > am adding JDK-8342998 to this PR. > > In a few places, I noted some "check permissions" methods that are now no-ops > that might be candidates for further cleanup (not directly related, so not > planned for jfx24). > > Finally, I deleted several unused methods in `MethodUtil` and `ReflectUtil` > (some of these were already removed in the corresponding JDK classes, and > some of them were unused after the changes to remove the call to > `getSecurityManager`). Looks good, noticed one detail to iron out modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 107: > 105: > 106: // Indicates permission to get the ClassLoader > 107: private static final RuntimePermission GET_CLASSLOADER_PERMISSION = I think this is unused and can be removed too ------------- PR Review: https://git.openjdk.org/jfx/pull/1631#pullrequestreview-2426361005 PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1836108609
