On Mon, 11 Nov 2024 08:12:08 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Replace 'TODO: SM removal:' comments with 'TODO: JDK-nnnnnnn:' >> - Additional cleanup of unused fields, imports, and comments related to >> permissions >> - Review comments: remove unused field, methods in FXMLLoader > > modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 107: > >> 105: >> 106: // Indicates permission to get the ClassLoader >> 107: private static final RuntimePermission GET_CLASSLOADER_PERMISSION = > > I think this is unused and can be removed too Thanks. I missed that. Related to this, the `needsClassLoaderPermissionCheck` method is similarly unused, so I'll remove that method as well. Also related, the private `checkClassLoaderPermission` method is now a no-op, and is only used in two places in this file, so I'll remove the method and the two calls. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1838230513
