On Fri, 8 Nov 2024 21:46:38 GMT, Kevin Rushforth <[email protected]> wrote:
> Ths PR removes all remaining calls to `System::getSecurityManager` and the
> `SecurityManager` class along with the `System.getGecurityManager() != null`
> code paths.
>
> As part of doing this, the last uses of `PermissionHelper` and
> `FXPermissions` were eliminated, so I deleted those two classes. Since
> `PermissionHelper` was the last remaining use of `AccessControlException`, I
> am adding JDK-8342998 to this PR.
>
> In a few places, I noted some "check permissions" methods that are now no-ops
> that might be candidates for further cleanup (not directly related, so not
> planned for jfx24).
>
> Finally, I deleted several unused methods in `MethodUtil` and `ReflectUtil`
> (some of these were already removed in the corresponding JDK classes, and
> some of them were unused after the changes to remove the call to
> `getSecurityManager`).
changes look good.
the only suggestion I have is to create the cleanup ticket, explain what needs
to be done, link this PR and use that JBS number in the comments instead of "SM
removal".
modules/javafx.base/src/main/java/com/sun/javafx/reflect/ReflectUtil.java line
82:
> 80: */
> 81: public static void checkPackageAccess(String name) {
> 82: @SuppressWarnings("removal")
will there be a ticket for further cleanup of unused/unnecessary methods?
modules/javafx.graphics/src/main/java/com/sun/javafx/font/FontFactory.java line
55:
> 53: public String[] getFontFullNames(String family);
> 54:
> 55: // TODO: SM removal: condider removing in a follow-up issue
maybe it's better to create a ticket and reference that instead?
modules/javafx.graphics/src/main/java/javafx/scene/input/Dragboard.java line 52:
> 50: @Override
> 51: Object getContentImpl(DataFormat dataFormat) {
> 52: if (dataAccessRestricted) {
this method can be deleted here
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1631#pullrequestreview-2424996037
PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1835103488
PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1835106214
PR Review Comment: https://git.openjdk.org/jfx/pull/1631#discussion_r1835109620
