On Fri, 19 Jul 2024 22:53:36 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add test case > > modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java > line 705: > >> 703: INLINE_OVERRIDES_USER_AGENT(RED_STYLESHEET, null, null, >> "-fx-background-color: #808080"), >> 704: INLINE_OVERRIDES_PROPERTY(RED_STYLESHEET, Color.BLUE, null, >> "-fx-background-color: #808080"), >> 705: INLINE_OVERRIDES_AUTHOR(RED_STYLESHEET, null, RED_STYLESHEET, >> "-fx-background-color: #808080"), > > Should we add other combinations: > (R,B,R,.. > (RED_INDIRECT,.. I've added cases where user agent stylesheet is `null`, but I've not added all combinations -- I feel there is no point to check if an inline style will override all combinations of user agent, property and author styles when there are already 3 cases that check if the inline style will override user agent, property and author styles individually. That said, I've added a few cases where ALL competing options are set (ie. for inline, a case where UA, property and author are set, and see if inline still wins). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686618843
