On Mon, 22 Jul 2024 14:10:56 GMT, John Hendrikx <[email protected]> wrote:
>> This change removes the origin determination from `resolveLookups`.
>> Instead, the origin from the style is used.
>>
>> Although a comment in the code alluded that this may cause problem with
>> `INLINE` styles, this is not the case. Whenever a `Node` is associated with
>> a `CssStyleHelper`, a suitable shared cache is determined for its use. This
>> already takes into account the presence of an inline style, and only nodes
>> with the same inline style can share such a cache. See `Cache#getStyleMap`
>> and specifically this fragment where an additional selector is added for the
>> inline style:
>>
>> if (hasInlineStyle) {
>> Selector selector =
>> cacheContainer.getInlineStyleSelector(inlineStyle);
>> if (selector != null) selectors.add(selector);
>> }
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments
modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java
line 689:
> 687: PROPERTY_OVERRIDES_INDIRECT_UA(RED_INDIRECT_STYLESHEET,
> Color.web("#808080"), null, null),
> 688:
> 689: // Property wins even if indirectly overridden by author or
> inline style (resolving of a lookup does not change priority of the user
> agent style)::
You might want to remove the double colon at the end of the sentence.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686712452
