> This change removes the origin determination from `resolveLookups`.  Instead, 
> the origin from the style is used.
> 
> Although a comment in the code alluded that this may cause problem with 
> `INLINE` styles, this is not the case. Whenever a `Node` is associated with a 
> `CssStyleHelper`, a suitable shared cache is determined for its use.  This 
> already takes into account the presence of an inline style, and only nodes 
> with the same inline style can share such a cache.  See `Cache#getStyleMap` 
> and specifically this fragment where an additional selector is added for the 
> inline style:
> 
>             if (hasInlineStyle) {
>                 Selector selector = 
> cacheContainer.getInlineStyleSelector(inlineStyle);
>                 if (selector != null) selectors.add(selector);
>             }

John Hendrikx has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains three commits:

 - Merge branch 'master' of https://git.openjdk.org/jfx into
   feature/remove-origin-priority-change-while-resolving
 - Add test case
 - Remove origin determination from resolveLookups

-------------

Changes: https://git.openjdk.org/jfx/pull/1503/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1503&range=02
  Stats: 116 lines in 2 files changed: 93 ins; 17 del; 6 mod
  Patch: https://git.openjdk.org/jfx/pull/1503.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1503/head:pull/1503

PR: https://git.openjdk.org/jfx/pull/1503

Reply via email to